Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改支付时签名字段缺少金额字段。修改支付通知时签名字段没有去掉空字段的判断 #3

Merged
merged 1 commit into from Dec 4, 2018

Conversation

ljyljy0211
Copy link

修改支付时签名字段缺少金额字段。修改支付通知时签名字段没有去掉空字段的判断

@coveralls
Copy link

coveralls commented Dec 3, 2018

Pull Request Test Coverage Report for Build 57

  • 0 of 7 (0.0%) changed or added relevant lines in 2 files are covered.
  • 171 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-29.2%) to 7.393%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Payment/Signer.php 0 3 0.0%
src/Payment/PaymentClient.php 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/Payment/PaymentClient.php 1 0.0%
src/Services/BaiduAbstractService.php 4 0.0%
src/Client/ParseResponseTrait.php 14 0.0%
src/BaiduClient.php 24 42.86%
src/Client/BaiduServiceClient.php 25 0.0%
src/Services/BaiduTemplate.php 42 0.0%
src/Client/BaiduHttpClient.php 61 6.12%
Totals Coverage Status
Change from base Build 53: -29.2%
Covered Lines: 38
Relevant Lines: 514

💛 - Coveralls

src/Payment/Signer.php Outdated Show resolved Hide resolved
src/Payment/PaymentClient.php Show resolved Hide resolved
@wi1dcard
Copy link
Owner

wi1dcard commented Dec 4, 2018

@ljyljy0211 根据之前有人提起的 Issue,此处需要去掉空值的判断,麻烦提交一下官方文档的链接,求证一下此处到底是否应该加空值的判断,谢谢。

@wi1dcard
Copy link
Owner

wi1dcard commented Dec 4, 2018

@ljyljy0211 我这边查看最新文档:https://dianshang.baidu.com/platform/doclist/index.html#!/doc/nuomiplus_2_base/sign_v2.md,暂时没有发现判断空值的代码。

@ljyljy0211
Copy link
Author

@ljyljy0211 我这边查看最新文档:https://dianshang.baidu.com/platform/doclist/index.html#!/doc/nuomiplus_2_base/sign_v2.md,暂时没有发现判断空值的代码。

你说的对,百度的sdk写的有问题,我们现在测试全部通过了。空值也要留着。
另外支付签名的的那个totalAmount新的写法中是需要的,老的接口不需要这个字段。

@wi1dcard
Copy link
Owner

wi1dcard commented Dec 4, 2018

@ljyljy0211 好的,感谢,我现在马上合并。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants