Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements on keepalive functionality #105

Merged
merged 3 commits into from
Apr 8, 2020
Merged

Enhancements on keepalive functionality #105

merged 3 commits into from
Apr 8, 2020

Conversation

Lenka42
Copy link
Collaborator

@Lenka42 Lenka42 commented Apr 3, 2020

@Lenka42 Lenka42 requested a review from Mixser April 3, 2020 14:33
@ashmigelski
Copy link
Collaborator

Great job!)

@ijl20
Copy link

ijl20 commented Apr 3, 2020

I can confirm this patch for files connection.py, handler.py, protocol.py fixes the timeout issue I was seeing with an open mosquitto subscription.
Good job.

@ijl20 ijl20 mentioned this pull request Apr 7, 2020
Closed
Mixser
Mixser reviewed Apr 7, 2020
View reviewed changes
gmqtt/mqtt/connection.py
if self._keepalive == value:
return
self._keepalive = value
self._keep_connection_callback = asyncio.get_event_loop().call_later(self._keepalive / 2, self._keep_connection)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to cancel previous (if it exists);

@Mixser Mixser merged commit c622160 into wialon:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mixser Mixser Mixser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Lenka42 @ashmigelski @ijl20 @Mixser