Format and update NEWS

wibeasley · Jan 3, 2014 · c3dd711 · c3dd711
1 parent 1d7c317
commit c3dd711
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 13 deletions.
diff --git a/NEWS b/NEWS
@@ -1,15 +1,17 @@
 Version 1.8.0.99
 ------------------------------------------------------------------------------
-Improvements to `rbind.fill` and by extension `*dply` and `join`:
-
-* `rbind.fill` handles non-numeric matrix columns (i.e. factors, characters, lists)
+* `rbind.fill` avoids array copying which had produced quadratic time
+  complexity. `*dply` of large numbers of groups should be faster.
   (Contributed by Peter Meilstrup)
 
-* `rbind.fill(x,y)` converts factor columns of Y to
-  character when columns of X are character. (Contributed by Peter Meilstrup)
+* `rbind.fill` handles non-numeric matrix columns (i.e. factor arrays,
+  character arrays, list arrays); also arrays with more than 2
+  dimensions can be used. (Contributed by Peter Meilstrup)
 
-* `join(x,y)` and `match_df(x,y)` now work when the key column in X is
-  character and Y is factor. (Contributed by Peter Meilstrup)
+* `rbind.fill(x,y)` converts factor columns of Y to character when
+  columns of X are character. `join(x,y)` and `match_df(x,y)` now work
+  when the key column in X is character and Y is factor. (Contributed
+  by Peter Meilstrup)
 
 * Fix faulty array allocation which caused problems when using `split_indices` 
   with large (> 2^24) vectors.  (Fixes #131)

diff --git a/R/rbind-fill.r b/R/rbind-fill.r
@@ -196,7 +196,7 @@ allocate_column <- function(example, nrows, dfs, var) {
           class(column) <<- class
           column
         } else {
-          what <- as.POSIXct(what, tz=tzone)
+          what <- as.POSIXct(what, tz = tzone)
           eval(assignment)
         }
       },

diff --git a/inst/tests/test-rbind.r b/inst/tests/test-rbind.r
@@ -211,8 +211,8 @@ test_that("zero col data frames ok", {
 })
 
 rbind_time <- function(size,
-                       classes=c("numeric", "character",
-                                 "array", "factor", "time")) {
+                       classes = c("numeric", "character",
+                                   "array", "factor", "time")) {
   unit <- quickdf(list(numeric = 1:3,
                        character = c("a", "b", "c"),
                        array = array(1:6, c(3,2)),
@@ -224,7 +224,7 @@ rbind_time <- function(size,
 
 get_rbind_times <- function(...) {
   rbind_time(10) #warm up/JIT
-  mdply(.fun=rbind_time, ...)
+  mdply(.fun = rbind_time, ...)
 }
 
 expect_linear_enough <- function(timings, size=2^10, threshold=0.03) {
@@ -245,12 +245,12 @@ test_that("rbind.fill performance linear", {
 
 test_that("rbind.fill performance linear with factors", {
   timings <- get_rbind_times(data.frame(size = 2^(1:10)),
-                                 classes=c("factor"))
+                             classes=c("factor"))
   expect_linear_enough(timings)
 })
 
 test_that("rbind.fill performance linear with times", {
   timings <- get_rbind_times(data.frame(size = 2^(1:10)),
-                                 classes=c("time"))
+                             classes=c("time"))
   expect_linear_enough(timings)
 })