Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor mistake in code example #30

Closed
philipwalton opened this issue Feb 25, 2020 · 0 comments · Fixed by #31
Closed

Minor mistake in code example #30

philipwalton opened this issue Feb 25, 2020 · 0 comments · Fixed by #31

Comments

@philipwalton
Copy link
Collaborator

The example show in the spec instructs users to call observer.takeRecords() to "force any pending records to be dispatched", but the takeRecords() method actually returns pending records rather than dispatching them.

The example should be updated to run the callback on the returned entries rather than just calling it.
npm1 added a commit that referenced this issue Feb 26, 2020
@npm1
Fix usage of takeRecords in example
7a0c5e0 
Fixes #30. Also fix a warning about not using 'must' in a non-normative section.
@npm1 npm1 mentioned this issue Feb 26, 2020
Merged
@npm1 npm1 closed this as completed in #31 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix usage of takeRecords in example WICG/layout-instability
1 participant
@philipwalton