-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What should maxBandwidth be if the technology is unknown? #17
Comments
As a specific example, for Android I don't see how to deduce a/b/g/n/ac. Here is a discussion of the issue. Android's WifiManager.getConnectionInfo().getLinkSpeed() could almost be mapped to the various protocols (but there is overlap between n and ac). Or we could simply return getLinkSpeed as the max bandwidth. Thoughts? |
If underlying connection type is "unknown" the current algorithm would lead to +Infinity: http://w3c.github.io/netinfo/#handling-changes-to-the-underlying-connection. Alternatively, we could pick the most conservative value for that connection type, but that would lead to "GSM" for cellular, which offers a whopping 10kbps - don't think that's a very useful value. I think +Infinity makes sense?
Josh, do you have some examples of what values [1] http://androidxref.com/4.4.4_r1/xref/frameworks/base/wifi/java/android/net/wifi/WifiInfo.java#349 |
Android's getLinkSpeed seems to return the currently configured wifi rate. For instance on my phone it changes from 54Mbps to 24Mbps as I move around. Since this is still a true maximum value, I think we should use it. Can we update to the spec to say "either use this table or if a more fine grained maximum value is available use that"? |
@jkarlin interesting, so the value must be changing based on some RSSI/modulation changes in the WiFi connection. I think it's reasonable to update the spec to allow more accurate estimates based on last hop network weather... This also allows the UA to refine estimates in the future, which is a nice plus.
@marcoscaceres this would require a bit of wordsmithing and an update to the algorithm. WDYT? Reasonable? P.S. As an aside, Android doesn't provide getLinkSpeed() for cellular connections, but it does provide cell signal strength, plus a few other variables, that we could (in theory) use to adjust the advertised maxDownlink. |
Agree.
Sounds like a really good addition. |
Where available, use the interface information to provide more accurate estimate of downlinkMax - e.g. based on signal strength and similar variables. If such information is not available, then fallback to the standardized maximum dowlink values. Closes #17
Took a run at updating wording + algorithm. PTAL. |
Looks good to me, thanks Ilya! |
There are going to be platforms where we may know the type of connection but not the specific technology (802.11a/b/g/n/ac etc.). What value do we use for maxBandwidth in those cases?
The text was updated successfully, but these errors were encountered: