downlinkMax can be determined by network weather #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where available, use the interface information to provide more accurate estimate of downlinkMax - e.g. based on signal strength and similar variables. If such information is not available, then fallback to the standardized maximum dowlink values. Closes #17
| The <dfn>underlying connection technology</dfn> represents the generation and/or version of the network connection being used by the device. For example, "HSPA" (3.5G) for cellular, or "802.11g" for Wi-Fi. This differs from the <a>connection type</a> exposed by the API, in that it is more fine grained. | ||
|
|
||
| Each <a>underlying connection technology</a> has an associated <dfn>maximum downlink speed</dfn>, which is the standardized, or generally accepted, maximum download data rate in <a>megabits</a> per second. The relationship between an <a>underlying connection technology</a> and its <a>maximum downlink speed</a> is captured in the <a>table of maximum downlink speeds</a>. | ||
| Each <a>underlying connection technology</a> has an associated <dfn>maximum downlink speed</dfn>, which is the maximum download data rate of the current network interface in <a>megabits</a> per second. The relationship between an <a>underlying connection technology</a> and its <a>maximum downlink speed</a> is determined by the properties of the current network interface (e.g signal strength, modulation algorithm, and other relevant "network weather" variables), or where such interface information is not available, is determined by the standardized, or generally accepted, maximum download data rate captured in the <a>table of maximum downlink speeds</a>. |
|
This all LGTM. Merge if you are ready. |
igrigorik
added a commit
that referenced
this pull request
Oct 9, 2014
downlinkMax can be determined by network weather
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where available, use the interface information to provide more accurate
estimate of downlinkMax - e.g. based on signal strength and similar
variables. If such information is not available, then fallback to the
standardized maximum dowlink values.
Closes #17