Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tensor Core support for convolutions #5

Merged
merged 2 commits into from Jul 15, 2020
Merged

Add Tensor Core support for convolutions #5

merged 2 commits into from Jul 15, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2020

This PR activates Tensor Cores for all convolution types in ETL.
Activating this on GPUs that have no Tensor Cores results in worse performance (at least with a NVIDIA GTX 1650), so this should be activated on-demand.
Though Tensor Cores appear to work with these changes, the performance remains the same as with them disabled (on a NVIDIA V100 GPU), so more testing is needed.

@wichtounet wichtounet marked this pull request as ready for review July 14, 2020 14:29
Copy link
Owner

@wichtounet wichtounet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

We should just rename the flag before we integrate this.

include/etl/impl/cudnn/conv.hpp Outdated Show resolved Hide resolved
@wichtounet wichtounet merged commit 687e362 into wichtounet:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant