Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wicket-scala-sample in master branch due to upstream change #10

Closed
mocleiri opened this issue Feb 8, 2011 · 3 comments
Closed

Fix wicket-scala-sample in master branch due to upstream change #10

mocleiri opened this issue Feb 8, 2011 · 3 comments

Comments

@mocleiri
Copy link
Member

mocleiri commented Feb 8, 2011

In recent builds on the master branch the wicket-scala-sample module is failing. The problem is:

[ERROR] /home/hudson/work/workspace/Wicket Stuff Core Java5 (wicket   1.5-SNAPSHOT)/jdk-1.5-parent/scala-extensions-parent/wicket-scala-sample/src/main/scala/org/wicketstuff/scala/sample/HelloWicketWorld.scala:71: error: ambiguous reference to overloaded definition,
[INFO] both method add in class FormComponent of type    (org.apache.wicket.validation.IValidator[_ >: T])org.apache.wicket.markup.html.form.FormComponent[T]
[INFO] and  method add in class Component of type 
(org.apache.wicket.behavior.Behavior*)org.apache.wicket.Component

[INFO] match argument types (org.apache.wicket.validation.validator.EmailAddressValidator)
[INFO]       add(new TextField("email").add(EmailAddressValidator.getInstance))
[INFO]                                  ^
[ERROR] one error found

Could someone who knows Scala remove the ambiguity so that the file will compile properly?

The full build log is here: http://wicketstuff.org/hudson/job/Wicket%20Stuff%20Core%20Java5%20%28wicket%201.5-SNAPSHOT%29/86/org.wicketstuff.scala$sample/console

@martin-g
Copy link
Member

With fa34e5d I upgraded the code to use latest Scala (2.8.1) and the respective versions for the testing libraries.
Now the compilation passes locally but the tests don't work.
I'll investigate further.

@akiraly
Copy link
Member

akiraly commented Feb 20, 2011

With commit b8e94ce I made a small change to the scala tests.
Now all modules and its tests in "jdk-1.5-parent" compile, run and pass on my computer. Can someone review that this was the correct way to fix the scala tests?

@martin-g
Copy link
Member

Yes, this solves the problem.
I simplified it a bit by removing the usage of JUnit trait.

reckart pushed a commit to reckart/core that referenced this issue Mar 31, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants