Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement stateless use of select2 choices #397

Closed
reiern70 opened this issue Apr 20, 2015 · 16 comments
Closed

implement stateless use of select2 choices #397

reiern70 opened this issue Apr 20, 2015 · 16 comments

Comments

@reiern70
Copy link
Contributor

https://github.com/ivaynberg/wicket-select2/pull/45/files

I do not know if support for connecting to mounted resources is supported on version of wicket-stuff? If not would it be of interest migrating PR above?

@martin-g
Copy link
Member

@shuraa , @solomax ^^

@solomax
Copy link
Contributor

solomax commented Apr 20, 2015

Will try to check it tomorrow
sorry for delay

@reiern70
Copy link
Contributor Author

Ok. Let me know if I can be of some help. What it does is:

1- Allows to point to an URL and read JSON from there.
2- Add an example of reading URL from mounted resource.

I use this a lot mo my applications (for stateless pages).

On Mon, Apr 20, 2015 at 12:52 PM, Maxim Solodovnik <notifications@github.com

wrote:

Will try to check it tomorrow
sorry for delay


Reply to this email directly or view it on GitHub
#397 (comment).

Regards - Ernesto Reinaldo Barreiro

@solomax
Copy link
Contributor

solomax commented Dec 8, 2015

Hello @reiern70, is this patch is actual for https://github.com/wicketstuff/core/tree/master/select2-parent ?
could you provide PR?

@reiern70
Copy link
Contributor Author

reiern70 commented Dec 9, 2015

It is for old select2... I cant ry to create PR for new master.... It works
fine for me with old seelct2.

On Tue, Dec 8, 2015 at 4:01 PM, Maxim Solodovnik notifications@github.com
wrote:

Hello @reiern70 https://github.com/reiern70, is this patch is actual
for https://github.com/wicketstuff/core/tree/master/select2-parent ?
could you provide PR?


Reply to this email directly or view it on GitHub
#397 (comment).

Regards - Ernesto Reinaldo Barreiro

@solomax
Copy link
Contributor

solomax commented Dec 10, 2015

can you please create 2 PR for wicket-6.x (old select2) and master (select2 4.0)

@reiern70
Copy link
Contributor Author

Created a PR for master

#443

On Thu, Dec 10, 2015 at 4:48 PM, Maxim Solodovnik notifications@github.com
wrote:

can you please create 2 PR for wicket-6.x (old select2) and master
(select2 4.0)


Reply to this email directly or view it on GitHub
#397 (comment).

Regards - Ernesto Reinaldo Barreiro

@reiern70
Copy link
Contributor Author

By the way

[image: Inline image 1]

I'm getting these JS errors and I'm almost certain that they are not
related to my changes...

On Tue, Dec 29, 2015 at 1:26 PM, Ernesto Reinaldo Barreiro <
reiern70@gmail.com> wrote:

Created a PR for master

#443

On Thu, Dec 10, 2015 at 4:48 PM, Maxim Solodovnik <
notifications@github.com> wrote:

can you please create 2 PR for wicket-6.x (old select2) and master
(select2 4.0)


Reply to this email directly or view it on GitHub
#397 (comment).

Regards - Ernesto Reinaldo Barreiro

Regards - Ernesto Reinaldo Barreiro

@reiern70
Copy link
Contributor Author

image

@reiern70
Copy link
Contributor Author

It seems they are.... :-( Let me debug and see how I broke it :-)

@reiern70
Copy link
Contributor Author

Everything seems to be working now. Can someone else give it a try?

@solomax
Copy link
Contributor

solomax commented Dec 29, 2015

Will be able to look at it tomorrow (or after NY)

@reiern70
Copy link
Contributor Author

No real hurry over here: and happy NY

@solomax
Copy link
Contributor

solomax commented Dec 29, 2015

Thanks for the contribution! will try to check it ASAP :)
Happy NY :))

@reiern70
Copy link
Contributor Author

Already using it on many screens of my project... E.g.

http://ns331816.ip-188-165-220.eu/register

Works like a charm :-)

On Tue, Dec 29, 2015 at 2:28 PM, Maxim Solodovnik notifications@github.com
wrote:

Thanks for the contribution! will try to check it ASAP :)
Happy NY :))


Reply to this email directly or view it on GitHub
#397 (comment).

Regards - Ernesto Reinaldo Barreiro

@solomax
Copy link
Contributor

solomax commented Dec 30, 2015

commented the PR, please check :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants