Make brew_is_upgradable mac function more robust

Rely on logic of `brew outdated` to decide whether a brew is upgradable. Fixes thoughtbot#276 and thoughtbot#282: * thoughtbot#276 * thoughtbot#282
wickett · Aug 31, 2014 · 6b7c8e7 · 6b7c8e7
1 parent 5754363
commit 6b7c8e7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/mac b/mac
@@ -55,10 +55,8 @@ brew_is_installed() {
 brew_is_upgradable() {
   local NAME=$(brew_expand_alias "$1")
 
-  local INSTALLED=$(brew ls --versions "$NAME" | awk '{print $NF}')
-  local LATEST=$(brew info "$NAME" 2>/dev/null | head -1 | awk '{gsub(/,/, ""); print $3}')
-
-  [ "$INSTALLED" != "$LATEST" ]
+  brew outdated --quiet "$NAME" >/dev/null
+  [[ $? -ne 0 ]]
 }
 
 brew_expand_alias() {

diff --git a/mac-components/mac-functions b/mac-components/mac-functions
@@ -17,10 +17,8 @@ brew_is_installed() {
 brew_is_upgradable() {
   local NAME=$(brew_expand_alias "$1")
 
-  local INSTALLED=$(brew ls --versions "$NAME" | awk '{print $NF}')
-  local LATEST=$(brew info "$NAME" 2>/dev/null | head -1 | awk '{gsub(/,/, ""); print $3}')
-
-  [ "$INSTALLED" != "$LATEST" ]
+  brew outdated --quiet "$NAME" >/dev/null
+  [[ $? -ne 0 ]]
 }
 
 brew_expand_alias() {