Skip to content

Commit

Permalink
Bug 1140900 - IPC Proxy for ScrollSubstringTo*, r=tbsaunde
Browse files Browse the repository at this point in the history
  • Loading branch information
rmottola committed Nov 11, 2019
1 parent 35d3364 commit 1f7de02
Show file tree
Hide file tree
Showing 5 changed files with 77 additions and 0 deletions.
32 changes: 32 additions & 0 deletions accessible/ipc/DocAccessibleChild.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -443,5 +443,37 @@ DocAccessibleChild::RecvRemoveFromSelection(const uint64_t& aID,
return true;
}

bool
DocAccessibleChild::RecvScrollSubstringTo(const uint64_t& aID,
const int32_t& aStartOffset,
const int32_t& aEndOffset,
const uint32_t& aScrollType)
{
HyperTextAccessible* acc = IdToHyperTextAccessible(aID);
if (acc) {
acc->ScrollSubstringTo(aStartOffset, aEndOffset, aScrollType);
}

return true;
}

bool
DocAccessibleChild::RecvScrollSubstringToPoint(const uint64_t& aID,
const int32_t& aStartOffset,
const int32_t& aEndOffset,
const uint32_t& aCoordinateType,
const int32_t& aX,
const int32_t& aY)
{
HyperTextAccessible* acc = IdToHyperTextAccessible(aID);
if (acc) {
acc->ScrollSubstringToPoint(aStartOffset, aEndOffset, aCoordinateType,
aX, aY);
}

return true;
}


}
}
12 changes: 12 additions & 0 deletions accessible/ipc/DocAccessibleChild.h
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,18 @@ class DocAccessibleChild : public PDocAccessibleChild
const int32_t& aSelectionNum,
bool* aSucceeded) override;

virtual bool RecvScrollSubstringTo(const uint64_t& aID,
const int32_t& aStartOffset,
const int32_t& aEndOffset,
const uint32_t& aScrollType) override;

virtual bool RecvScrollSubstringToPoint(const uint64_t& aID,
const int32_t& aStartOffset,
const int32_t& aEndOffset,
const uint32_t& aCoordinateType,
const int32_t& aX,
const int32_t& aY) override;

private:
bool PersistentPropertiesToArray(nsIPersistentProperties* aProps,
nsTArray<Attribute>* aAttributes);
Expand Down
8 changes: 8 additions & 0 deletions accessible/ipc/PDocAccessible.ipdl
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,14 @@ child:
returns(bool aSucceeded);
prio(high) sync RemoveFromSelection(uint64_t aID, int32_t aSelectionNum)
returns(bool aSucceeded);

ScrollSubstringTo(uint64_t aID, int32_t aStartOffset, int32_t aEndOffset,
uint32_t aScrollType);
ScrollSubstringToPoint(uint64_t aID,
int32_t aStartOffset,
int32_t aEndOffset,
uint32_t aCoordinateType,
int32_t aX, int32_t aY);
};

}
Expand Down
17 changes: 17 additions & 0 deletions accessible/ipc/ProxyAccessible.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -286,5 +286,22 @@ ProxyAccessible::RemoveFromSelection(int32_t aSelectionNum)
return retVal;
}

void
ProxyAccessible::ScrollSubstringTo(int32_t aStartOffset, int32_t aEndOffset,
uint32_t aScrollType)
{
unused << mDoc->SendScrollSubstringTo(mID, aStartOffset, aEndOffset, aScrollType);
}

void
ProxyAccessible::ScrollSubstringToPoint(int32_t aStartOffset,
int32_t aEndOffset,
uint32_t aCoordinateType,
int32_t aX, int32_t aY)
{
unused << mDoc->SendScrollSubstringToPoint(mID, aStartOffset, aEndOffset,
aCoordinateType, aX, aY);
}

}
}
8 changes: 8 additions & 0 deletions accessible/ipc/ProxyAccessible.h
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,14 @@ class ProxyAccessible

bool RemoveFromSelection(int32_t aSelectionNum);

void ScrollSubstringTo(int32_t aStartOffset, int32_t aEndOffset,
uint32_t aScrollType);

void ScrollSubstringToPoint(int32_t aStartOffset,
int32_t aEndOffset,
uint32_t aCoordinateType,
int32_t aX, int32_t aY);

/**
* Allow the platform to store a pointers worth of data on us.
*/
Expand Down

0 comments on commit 1f7de02

Please sign in to comment.