Bug 1066234 - Part 1: Parser support for 'extends' in ES6 Classes.

rmottola · Apr 17, 2019 · 7782e67 · 7782e67
1 parent f28b6f2
commit 7782e67
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 9 deletions.
diff --git a/js/src/frontend/Parser.cpp b/js/src/frontend/Parser.cpp
@@ -5728,20 +5728,32 @@ Parser<FullParseHandler>::classStatement()
         return null();
     }
 
-    // Because the binding definitions keep track of their blockId, we need to
-    // create at least the inner binding later. Keep track of the name's position
-    // in order to provide it for the nodes created later.
-    TokenPos namePos = pos();
-
-    MUST_MATCH_TOKEN(TOK_LC, JSMSG_CURLY_BEFORE_CLASS);
-
     bool savedStrictness = setLocalStrictMode(true);
 
     StmtInfoPC classStmt(context);
     ParseNode *classBlock = pushLexicalScope(&classStmt);
     if (!classBlock)
         return null();
 
+    // Because the binding definitions keep track of their blockId, we need to
+    // create at least the inner binding later. Keep track of the name's position
+    // in order to provide it for the nodes created later.
+    TokenPos namePos = pos();
+
+    ParseNode *classHeritage = null();
+    bool hasHeritage;
+    if (!tokenStream.matchToken(&hasHeritage, TOK_EXTENDS))
+        return null();
+    if (hasHeritage) {
+        if (!tokenStream.getToken(&tt))
+            return null();
+        classHeritage = memberExpr(tt, true);
+        if (!classHeritage)
+            return null();
+    }
+
+    MUST_MATCH_TOKEN(TOK_LC, JSMSG_CURLY_BEFORE_CLASS);
+
     ParseNode *classMethods = propertyList(ClassBody);
     if (!classMethods)
         return null();
@@ -5763,7 +5775,7 @@ Parser<FullParseHandler>::classStatement()
 
     MOZ_ALWAYS_TRUE(setLocalStrictMode(savedStrictness));
 
-    return handler.newClass(nameNode, null(), classBlock);
+    return handler.newClass(nameNode, classHeritage, classBlock);
 }
 
 template <>

diff --git a/js/src/frontend/TokenKind.h b/js/src/frontend/TokenKind.h
@@ -111,6 +111,7 @@
     macro(EXPORT,       "keyword 'export'") \
     macro(IMPORT,       "keyword 'import'") \
     macro(CLASS,        "keyword 'class'") \
+    macro(EXTENDS,      "keyword 'extends'") \
     macro(RESERVED,     "reserved keyword") \
     /* reserved keywords in strict mode */ \
     macro(STRICT_RESERVED, "reserved keyword") \

diff --git a/js/src/frontend/TokenStream.cpp b/js/src/frontend/TokenStream.cpp
@@ -988,6 +988,7 @@ TokenStream::checkForKeyword(const KeywordInfo* kw, TokenKind* ttp)
     if (kw->tokentype == TOK_RESERVED
 #ifndef JS_HAS_CLASSES
         || kw->tokentype == TOK_CLASS
+        || kw->tokentype == TOK_EXTENDS
 #endif
         )
     {

diff --git a/js/src/vm/Keywords.h b/js/src/vm/Keywords.h
@@ -44,9 +44,9 @@
     macro(import, import, TOK_IMPORT, JSVERSION_DEFAULT) \
     macro(export, export, TOK_EXPORT, JSVERSION_DEFAULT) \
     macro(class, class_, TOK_CLASS, JSVERSION_DEFAULT) \
+    macro(extends, extends, TOK_EXTENDS, JSVERSION_DEFAULT) \
     /* Reserved keywords. */ \
     macro(enum, enum_, TOK_RESERVED, JSVERSION_DEFAULT) \
-    macro(extends, extends, TOK_RESERVED, JSVERSION_DEFAULT) \
     macro(super, super, TOK_RESERVED, JSVERSION_DEFAULT) \
     /* Future reserved keywords, but only in strict mode. */ \
     macro(implements, implements, TOK_STRICT_RESERVED, JSVERSION_DEFAULT) \