Skip to content

Commit

Permalink
Bug 1188462 - Fix inclusion of skia headers to use correct directory …
Browse files Browse the repository at this point in the history
…prefixes.
  • Loading branch information
rmottola committed Feb 15, 2019
1 parent 445c1a6 commit cb8a82d
Show file tree
Hide file tree
Showing 28 changed files with 67 additions and 65 deletions.
25 changes: 12 additions & 13 deletions gfx/2d/DrawTargetSkia.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,24 +8,23 @@
#include "SourceSurfaceSkia.h"
#include "ScaledFontBase.h"
#include "ScaledFontCairo.h"
#include "skia/SkGpuDevice.h"
#include "skia/SkBitmapDevice.h"
#include "skia/include/core/SkBitmapDevice.h"
#include "FilterNodeSoftware.h"

#ifdef USE_SKIA_GPU
#include "skia/SkGpuDevice.h"
#include "skia/GrGLInterface.h"
#include "skia/include/gpu/SkGpuDevice.h"
#include "skia/include/gpu/gl/GrGLInterface.h"
#endif

#include "skia/SkTypeface.h"
#include "skia/SkGradientShader.h"
#include "skia/SkBlurDrawLooper.h"
#include "skia/SkBlurMaskFilter.h"
#include "skia/SkColorFilter.h"
#include "skia/SkDropShadowImageFilter.h"
#include "skia/SkLayerRasterizer.h"
#include "skia/SkLayerDrawLooper.h"
#include "skia/SkDashPathEffect.h"
#include "skia/include/core/SkTypeface.h"
#include "skia/include/effects/SkGradientShader.h"
#include "skia/include/effects/SkBlurDrawLooper.h"
#include "skia/include/effects/SkBlurMaskFilter.h"
#include "skia/include/core/SkColorFilter.h"
#include "skia/include/effects/SkDropShadowImageFilter.h"
#include "skia/include/effects/SkLayerRasterizer.h"
#include "skia/include/effects/SkLayerDrawLooper.h"
#include "skia/include/effects/SkDashPathEffect.h"
#include "Logging.h"
#include "Tools.h"
#include "DataSurfaceHelpers.h"
Expand Down
6 changes: 3 additions & 3 deletions gfx/2d/DrawTargetSkia.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
#define _MOZILLA_GFX_SOURCESURFACESKIA_H

#ifdef USE_SKIA_GPU
#include "skia/GrContext.h"
#include "skia/GrGLInterface.h"
#include "skia/include/gpu/GrContext.h"
#include "skia/include/gpu/gl/GrGLInterface.h"
#endif

#include "skia/SkCanvas.h"
#include "skia/include/core/SkCanvas.h"

#include "2D.h"
#include "HelpersSkia.h"
Expand Down
8 changes: 4 additions & 4 deletions gfx/2d/HelpersSkia.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
#define MOZILLA_GFX_HELPERSSKIA_H_

#include "2D.h"
#include "skia/SkCanvas.h"
#include "skia/SkDashPathEffect.h"
#include "skia/SkShader.h"
#include "skia/include/core/SkCanvas.h"
#include "skia/include/effects/SkDashPathEffect.h"
#include "skia/include/core/SkShader.h"
#ifdef USE_SKIA_GPU
#include "skia/GrTypes.h"
#include "skia/include/gpu/GrTypes.h"
#endif
#include "mozilla/Assertions.h"
#include <vector>
Expand Down
2 changes: 1 addition & 1 deletion gfx/2d/PathSkia.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#define MOZILLA_GFX_PATH_SKIA_H_

#include "2D.h"
#include "skia/SkPath.h"
#include "skia/include/core/SkPath.h"

namespace mozilla {
namespace gfx {
Expand Down
2 changes: 1 addition & 1 deletion gfx/2d/Scale.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#ifdef USE_SKIA
#include "HelpersSkia.h"
#include "skia/SkBitmap.h"
#include "skia/include/core/SkBitmap.h"
#include "image_operations.h"
#endif

Expand Down
2 changes: 1 addition & 1 deletion gfx/2d/ScaledFontBase.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#ifdef USE_SKIA
#include "PathSkia.h"
#include "skia/SkPaint.h"
#include "skia/include/core/SkPaint.h"
#endif

#ifdef USE_CAIRO
Expand Down
4 changes: 2 additions & 2 deletions gfx/2d/ScaledFontBase.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#endif

#ifdef USE_SKIA
#include "skia/SkPath.h"
#include "skia/SkTypeface.h"
#include "skia/include/core/SkPath.h"
#include "skia/include/core/SkTypeface.h"
#endif
#ifdef USE_CAIRO_SCALED_FONT
#include "cairo.h"
Expand Down
4 changes: 2 additions & 2 deletions gfx/2d/ScaledFontCairo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
#endif

#if defined(USE_SKIA) && defined(MOZ_ENABLE_FREETYPE)
#include "skia/SkTypeface.h"
#include "skia/SkTypeface_cairo.h"
#include "skia/include/core/SkTypeface.h"
#include "skia/include/ports/SkTypeface_cairo.h"
#endif

#include <string>
Expand Down
6 changes: 3 additions & 3 deletions gfx/2d/ScaledFontMac.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
#include "ScaledFontMac.h"
#ifdef USE_SKIA
#include "PathSkia.h"
#include "skia/SkPaint.h"
#include "skia/SkPath.h"
#include "skia/SkTypeface_mac.h"
#include "skia/include/core/SkPaint.h"
#include "skia/include/core/SkPath.h"
#include "skia/include/ports/SkTypeface_mac.h"
#endif
#include "DrawTargetCG.h"
#include <vector>
Expand Down
2 changes: 1 addition & 1 deletion gfx/2d/ScaledFontWin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#include "ScaledFontBase.h"

#ifdef USE_SKIA
#include "skia/SkTypeface_win.h"
#include "skia/include/ports/SkTypeface_win.h"
#endif

namespace mozilla {
Expand Down
9 changes: 6 additions & 3 deletions gfx/2d/SourceSurfaceSkia.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,15 @@

#include "Logging.h"
#include "SourceSurfaceSkia.h"
#include "skia/SkBitmap.h"
#include "skia/SkDevice.h"
#include "skia/include/core/SkBitmap.h"
#include "skia/include/core/SkDevice.h"
#include "HelpersSkia.h"
#include "DrawTargetSkia.h"
#include "DataSurfaceHelpers.h"
#include "skia/SkGrPixelRef.h"

#ifdef USE_SKIA_GPU
#include "skia/include/gpu/SkGrPixelRef.h"
#endif

namespace mozilla {
namespace gfx {
Expand Down
4 changes: 2 additions & 2 deletions gfx/2d/SourceSurfaceSkia.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@

#include "2D.h"
#include <vector>
#include "skia/SkCanvas.h"
#include "skia/SkBitmap.h"
#include "skia/include/core/SkCanvas.h"
#include "skia/include/core/SkBitmap.h"

class GrContext;

Expand Down
2 changes: 1 addition & 1 deletion gfx/2d/convolver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

#include <algorithm>

#include "skia/SkTypes.h"
#include "skia/include/core/SkTypes.h"


#if defined(USE_SSE2)
Expand Down
2 changes: 1 addition & 1 deletion gfx/2d/convolver.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
#include "base/basictypes.h"
#include "base/cpu.h"
#include "mozilla/Assertions.h"
#include "skia/SkTypes.h"
#include "skia/include/core/SkTypes.h"

// avoid confusion with Mac OS X's math library (Carbon)
#if defined(__APPLE__)
Expand Down
2 changes: 1 addition & 1 deletion gfx/2d/convolverLS3.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

#include "convolver.h"
#include <algorithm>
#include "skia/SkTypes.h"
#include "skia/include/core/SkTypes.h"

#if defined(_MIPS_ARCH_LOONGSON3A)

Expand Down
2 changes: 1 addition & 1 deletion gfx/2d/convolverLS3.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

#include <algorithm>

#include "skia/SkTypes.h"
#include "skia/include/core/SkTypes.h"

namespace skia {

Expand Down
2 changes: 1 addition & 1 deletion gfx/2d/convolverSSE2.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

#include "convolver.h"
#include <algorithm>
#include "skia/SkTypes.h"
#include "skia/include/core/SkTypes.h"

#include <emmintrin.h> // ARCH_CPU_X86_FAMILY was defined in build/config.h

Expand Down
2 changes: 1 addition & 1 deletion gfx/2d/convolverSSE2.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

#include <algorithm>

#include "skia/SkTypes.h"
#include "skia/include/core/SkTypes.h"

namespace skia {

Expand Down
8 changes: 4 additions & 4 deletions gfx/2d/image_operations.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@

#include "base/stack_container.h"
#include "convolver.h"
#include "skia/SkColorPriv.h"
#include "skia/SkBitmap.h"
#include "skia/SkRect.h"
#include "skia/SkFontHost.h"
#include "skia/include/core/SkColorPriv.h"
#include "skia/include/core/SkBitmap.h"
#include "skia/include/core/SkRect.h"
#include "skia/include/core/SkFontHost.h"

namespace skia {

Expand Down
4 changes: 2 additions & 2 deletions gfx/2d/image_operations.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@
#ifndef SKIA_EXT_IMAGE_OPERATIONS_H_
#define SKIA_EXT_IMAGE_OPERATIONS_H_

#include "skia/SkTypes.h"
#include "skia/include/core/SkTypes.h"
#include "Types.h"
#include "convolver.h"
#include "skia/SkRect.h"
#include "skia/include/core/SkRect.h"

class SkBitmap;
struct SkIRect;
Expand Down
4 changes: 2 additions & 2 deletions gfx/gl/SkiaGLGlue.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "skia/GrContext.h"
#include "skia/GrGLInterface.h"
#include "skia/include/gpu/GrContext.h"
#include "skia/include/gpu/gl/GrGLInterface.h"
#include "mozilla/gfx/2D.h"
#include "mozilla/ThreadLocal.h"
#include "mozilla/DebugOnly.h"
Expand Down
4 changes: 2 additions & 2 deletions gfx/gl/SkiaGLGlue.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
#ifdef USE_SKIA_GPU

#include "GLContext.h"
#include "skia/GrGLInterface.h"
#include "skia/GrContext.h"
#include "skia/include/gpu/gl/GrGLInterface.h"
#include "skia/include/gpu/GrContext.h"
#include "mozilla/gfx/HelpersSkia.h"

namespace mozilla {
Expand Down
4 changes: 2 additions & 2 deletions gfx/layers/basic/BasicCompositor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
#include "ImageContainer.h"
#include "gfxPrefs.h"
#ifdef MOZ_ENABLE_SKIA
#include "skia/SkCanvas.h" // for SkCanvas
#include "skia/SkBitmapDevice.h" // for SkBitmapDevice
#include "skia/include/core/SkCanvas.h" // for SkCanvas
#include "skia/include/core/SkBitmapDevice.h" // for SkBitmapDevice
#else
#define PIXMAN_DONT_DEFINE_STDINT
#include "pixman.h" // for pixman_f_transform, etc
Expand Down
4 changes: 2 additions & 2 deletions gfx/layers/basic/BasicLayerManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@
#include "nsRegion.h" // for nsIntRegion, etc
#include "nsTArray.h" // for nsAutoTArray
#ifdef MOZ_ENABLE_SKIA
#include "skia/SkCanvas.h" // for SkCanvas
#include "skia/SkBitmapDevice.h" // for SkBitmapDevice
#include "skia/include/core/SkCanvas.h" // for SkCanvas
#include "skia/include/core/SkBitmapDevice.h" // for SkBitmapDevice
#else
#define PIXMAN_DONT_DEFINE_STDINT
#include "pixman.h" // for pixman_f_transform, etc
Expand Down
12 changes: 6 additions & 6 deletions gfx/skia/skia/include/config/SkUserConfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -179,21 +179,21 @@
//#define SK_ATOMICS_PLATFORM_H "SkAtomics_xxx.h"
//#define SK_MUTEX_PLATFORM_H "SkMutex_xxx.h"
#if defined(_MSC_VER)
# define SK_ATOMICS_PLATFORM_H "skia/SkAtomics_win.h"
# define SK_ATOMICS_PLATFORM_H "../../src/ports/SkAtomics_win.h"
#else
# define SK_ATOMICS_PLATFORM_H "skia/SkAtomics_sync.h"
# define SK_ATOMICS_PLATFORM_H "../../src/ports/SkAtomics_sync.h"
#endif

#if defined(_WIN32)
# define SK_MUTEX_PLATFORM_H "skia/SkMutex_win.h"
# define SK_MUTEX_PLATFORM_H "../../src/ports/SkMutex_win.h"
#else
# define SK_MUTEX_PLATFORM_H "skia/SkMutex_pthread.h"
# define SK_MUTEX_PLATFORM_H "../../src/ports/SkMutex_pthread.h"
#endif

#if defined(SK_CPU_ARM32) || defined(SK_CPU_ARM64)
# define SK_BARRIERS_PLATFORM_H "skia/SkBarriers_arm.h"
# define SK_BARRIERS_PLATFORM_H "../../src/ports/SkBarriers_arm.h"
#else
# define SK_BARRIERS_PLATFORM_H "skia/SkBarriers_x86.h"
# define SK_BARRIERS_PLATFORM_H "../../src/ports/SkBarriers_x86.h"
#endif

// On all platforms we have this byte order
Expand Down
2 changes: 1 addition & 1 deletion gfx/skia/skia/include/core/SkShader.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#include "SkMask.h"
#include "SkMatrix.h"
#include "SkPaint.h"
#include "GrColor.h"
#include "../gpu/GrColor.h"

class SkPath;
class SkPicture;
Expand Down
2 changes: 1 addition & 1 deletion gfx/thebes/gfxPlatform.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@

#include "mozilla/Hal.h"
#ifdef USE_SKIA
#include "skia/SkGraphics.h"
#include "skia/include/core/SkGraphics.h"
# ifdef USE_SKIA_GPU
# include "SkiaGLGlue.h"
# endif
Expand Down
2 changes: 1 addition & 1 deletion image/Downscaler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#include "gfxPrefs.h"
#include "image_operations.h"
#include "convolver.h"
#include "skia/SkTypes.h"
#include "skia/include/core/SkTypes.h"

using std::max;
using std::swap;
Expand Down

0 comments on commit cb8a82d

Please sign in to comment.