馃挭 Add retry logic #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update - adding error handling and a loop to reattempting
I shouldn't code in a browser without a terminal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicating #41 since I can't push to the fork
Fixes: #40
Description:
Currently, we are utilizing this workflow for our pull requests (PRs). However, we have encountered instances where it fails to hit the specified URL, requiring manual triggers. After a thorough investigation, we have identified the root cause to be intermittent issues with URL accessibility.
Features:
Improved Reliability: To mitigate the intermittent URL accessibility issues, the workflow has been enhanced to make two additional attempts if the first attempt fails. This improves the overall reliability of the workflow.
Robust Flow: In case of failure, the workflow has been modified to gracefully handle the situation without breaking the overall flow. This ensures smoother PR processing even when issues arise.
Enhanced Feedback: To provide clearer feedback, error, and success messages have been enhanced with emojis. This visual representation makes it easier to identify the status of the workflow at a glance.
Please review the updated description and features to accurately reflect the modifications made.
Screenshot
PageInsight Change
Figure: Tested on your forked repo, showing error on the first instance, and ran successfully on the second attempt
PR I tested on: SSWConsulting/SSW.Website#812
Related issue: 馃挌 PR check - Pagespeed insights fails on first run#785