Fix swift 5.4 linux compatibility #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the release of swift 5.4 the ClassMetadataLayout was changed to not include fields used for Objective-C interoperability on platforms which do not support it. See apple/swift@38fc849#diff-22fb9f1513d9c05f34d493826b4553bba65a4336a41ae4413678feec549db3a5
|
|
|
With The docs read like that package is only available if the objective-c runtime is available. So that is probably then the way to go. |
|
There are about 5 or 6 ObjC runtimes supported by clang, but I think only the Apple one is supported by Swift (and coming w/ a modmap). So I'm not entirely sure which one is better :-) |
This was referenced Jun 30, 2021
|
If I may ping you @wickwirew, would love to get a review on this to get the fix upstream (as well as my other PRs). |
wickwirew
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #92, swift 5.4 change the
ClassMetadataLayoutfor platforms that do not support Objective-C interoperability. This resulted in Runtime crashing when running on those platforms with the newest swift releases.This PR fixes this issue by adjusting the
ClassMetadataLayouton those platforms.I'm using the
#if !swift(>=5.4) || canImport(Darwin). Not entirely sure ifcanImport(Darwin)is the proper check for availability of Objective-C interoperability (works though). Happy for any feedback.I have another PR ready which adds some CI integration with GitHub to test the framework on all the available linux distortions. This PR passes all tests on all platforms: Actions Run.
I chose to do the CI PR separately so this fix can get merged faster.