Fix Factory createInstance for class types on linux platforms
#95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My comment in #49 (comment) explains the issue and how to resolve (to my understanding and knowledge) in detail.
The changes in this PR have proven to be working: see GitHub CI Run (Note this run includes the PRs #93 and #94)
This PR makes two adjustments to the
createClassmethod:let instanceSize = Int32(md.pointer.pointee.classSize)withlet instanceSize = Int32(md.pointer.pointee.instanceSize)To my knowledge and careful reading through the Class Metadata Layout docs to me, using
.classSizehere seems wrong. The value is not constant across platforms whileinstanceSizeis. I'm not really an expert with the Swift Runtime, so feel free to correct me if I'm wrong.Further, this PR reenables some tests cases which were previously skipped on linux platforms (which allowed for this issue being unnoticed).