This repository has been archived by the owner on Nov 8, 2021. It is now read-only.
Authorizing users based on AWS IAM User Groups #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvanbaak
reviewed
Feb 25, 2017
| aws iam get-ssh-public-key --user-name "$SaveUserName" --ssh-public-key-id "$KeyId" --encoding SSH --query "SSHPublicKey.SSHPublicKeyBody" --output text | ||
| # Specify IAM group(s) separated by spaces to import users. | ||
| # Specify "##ALL##" (including the double quotes) to import all users | ||
| IAMGroup=("##ALL##") |
There was a problem hiding this comment.
Personally I would do this in import_users.sh instead of here. Putting it here makes logging in with ssh even slower. And it is already slow because of the API calls.
While it works, this script does a lot now that it doesn't have to do. If you only import the users in the IAM groups, you also limit the amount of users on the system.
So I would suggest moving this code to the import_users.sh. The code itself looks good to me :)
There was a problem hiding this comment.
I agree with you. I'm of the same opinion too. The ultimate call is with owner of the repository. I just implemented their suggestion. 😉
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Resolves comment #281132929)