Limit usernames to 32 chars per man useradd

[nickjwebb]

Hit this limit when CFN created users were pulled by import_users.sh (> 32 characters long).

Sorry for the kick patch, but this gets beyond the error. When useradd is called with a username > 32 characters, it returns an error code and message saying "invalid username" or similar. This was blocking other users under the 32 character limit from creating. FWIW, I don't need the script to work with these users, simply don't want it to fail completely.

[michaelwittig]

so I think it would be better to not add users when the clean_username is longer than 32 chars?
otherwise we could run into the issue that two users become one username which must be avoided.
I will add the 32 characters to the limitations

[nickjwebb]

Yes agreed, outputting a warning that the user will not be created, then continuing with other users would be the right way to deal with this.

…

On Apr 25, 2017 10:14, "Michael Wittig" ***@***.***> wrote: so I think it would be better to not add users when the clean_username is longer than 32 chars? otherwise we could run into the issue that two users become one username which must be avoided. I will add the 32 characters to the limitations — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAum7E_W1Rht1jNOGFJQz-agKJpyXbs3ks5rzin0gaJpZM4M_y4Y> .

[michaelwittig]

I created an issue #40 and will close this PR

[michaelwittig]

I open #41 to implement the length check