Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat window should only handle keys when the input field has focus #2066

Closed
bunnybot opened this issue Sep 9, 2019 · 2 comments · Fixed by #5944
Closed

Chat window should only handle keys when the input field has focus #2066

bunnybot opened this issue Sep 9, 2019 · 2 comments · Fixed by #5944
Assignees
@stonerl
Labels
chat Multiplayer chat system enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed ui User interface
Milestone
v1.2

Comments

@bunnybot
Copy link

bunnybot commented Sep 9, 2019 •
edited

When the chat window is open or minimzed, keyboard shortcuts for everything else won't work. This could be solved by only handling the keys when the input field is focused.

Also, if the user left-clicks anywhere inside the chat window, the input field should be focused.

Imported from Launchpad using lp2gh.
@bunnybot bunnybot added chat Multiplayer chat system lowhangingfruit ui User interface labels Sep 9, 2019
@bunnybot bunnybot added this to the build21-rc1 milestone Sep 9, 2019
@TinoM TinoM added good first issue Good for newcomers and removed lowhangingfruit labels Sep 11, 2019
@gunchleoc gunchleoc added enhancement New feature or request and removed Wishlist labels Sep 13, 2019
@gunchleoc gunchleoc added this to Needs triage in Issue triage Sep 13, 2019
@gunchleoc gunchleoc removed this from To Do in Issue triage Sep 29, 2019
stonerl added a commit that referenced this issue Nov 20, 2019
@stonerl
fixes #2066
48b1258
@stonerl stonerl mentioned this issue Nov 20, 2019
Merged
@stonerl
Copy link
Member

stonerl commented Nov 20, 2019

I fixed this. The only problem I have is that I'd like to unfocus the editbox when the window hasn't focus. Somehow I'm not able to achieve this. Hints are welcome 😄

@stonerl stonerl added the help wanted Extra attention is needed label Nov 20, 2019
@stonerl stonerl self-assigned this Nov 20, 2019
stonerl added a commit that referenced this issue Nov 23, 2019
@stonerl
Revert "fixes #2066"
f9349f0 
This reverts commit 48b1258.
stonerl added a commit that referenced this issue Dec 6, 2019
@stonerl
Revert "Revert "fixes #2066""
c551a5c 
This reverts commit f9349f0.
@stonerl stonerl mentioned this issue Dec 7, 2019
Merged
stonerl added a commit that referenced this issue Dec 10, 2019
@stonerl
Revert "Revert "Revert "fixes #2066"""
6cb37a9 
This reverts commit c551a5c.
stonerl added a commit that referenced this issue Dec 25, 2019
@stonerl
Fix Multiplayer Setup Window (#3580)
5a47af3 
* Chatpanel is now properly aligned to the ok and back button
* Chatpanel only has focus when clicked on it (removes cursor when not active)
* Peaceful Mode checkbox has fixed spacing above and below
* Text for missing map/savegame files has been moved to map_info_
* client_info_ has been remove since it does not provide any information of value and only duplicates information already available.
* Full width button for map select.
* Start Game button has been moved below the back button.

fixes #3578 #2066
@gunchleoc
Copy link
Contributor

The best thing I can say right now is "with lots of digging though the control flow in the code". The focus issue is non-trivial.

@Noordfrees Noordfrees modified the milestones: build21-rc1, build22-rc1 Apr 14, 2020
@Noordfrees Noordfrees modified the milestones: v1.0, v1.1 Jan 4, 2021
@Noordfrees Noordfrees modified the milestones: v1.1, v1.2 Apr 22, 2022
@tothxa tothxa mentioned this issue Jun 18, 2023
Merged
@Noordfrees Noordfrees modified the milestones: v1.2, v1.3 Jun 20, 2023
@Noordfrees Noordfrees modified the milestones: v1.3, v1.2 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stonerl stonerl

Labels
chat Multiplayer chat system enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed ui User interface
Projects
None yet
Milestone
v1.2
Development

Successfully merging a pull request may close this issue.

Debugconsole and input history improvements tothxa/widelands
5 participants
@stonerl @TinoM @gunchleoc @bunnybot @Noordfrees