More detailed soldier preferences for military- and trainingsites

[Noordfrees]

https://www.widelands.org/forum/topic/4804
https://www.widelands.org/forum/topic/4803

• Add a third radiobutton to militarysites' soldier preference which cancels soldier exchange for this site
• Add those three buttons to trainingsites as well so players can choose between training preferably soldiers who have already received training from (other) sites (default, post-2940 better trainingsite soldier selection #3835 behaviour), or any soldiers (pre-2940 better trainingsite soldier selection #3835 behaviour), or enforce accepting rookies only
• Additionally have a checkbox or togglebutton in trainingsite windows to disable kicking out soldiers when training attempts keeps failing (default: kickout enabled)
• We'll need a third entry in MilitarySite::SoldierPreference and appropriate saveloading support, and everything needs to be exposed to the lua interface and constructionsite settings as well
• Explain all this in the military tutorial

---

Further suggestions from https://www.widelands.org/forum/topic/5090

• A fourth radiobutton "Prefer Average" that prefers soldiers whose training levels are close to the average levels of all the player's soldiers
• UI to manually exchange two specified soldiers between two militarysites
  → This would automatically set the soldier preference to No Exchange unless a modifier like Ctrl is held.
  → Might complicate the user interface too much?
• Add a modifier (Ctrl) to automatically decrease the capacity by 1 when manually expelling a soldier
• Add a priority slider for soldier priorities to all military- and trainingsites, so the player can ensure that soldiers are e.g. preferably sent to training before occupying a milsite

[tppq]

The build request mentioned by Noordfrees fixes #2940. No radio buttons added, so it does not address this. The commit might make the need for radio buttons go away for trainingsites. Military sites are unaffected.

[tppq]

Add those three buttons to trainingsites as well so players can choose between training preferably soldiers who have already received training from (other) sites (default, post-#3835 behaviour), or any soldiers (pre-#3835 behaviour), or enforce accepting rookies only

Should these be preferences of enforcing? In other words, if already-trained soldiers are not present, should the site remain idle or eventually obtain non-preferred untrained soldiers? If evade-1 soldiers are available, should they be out of luck if enforcing untrained only? (I vote for preferences, not enforcement)

Should the requirement of previous training depend on whether the previous training was give here or not (non-Frisians)? (currently not in code)

Should there be an option to require that the soldiers is at least on minimum level for all trainable arts (Frisians)? (currently not in code)

Should the discriminating level be user-adjustable, or should it follow the supply like now? (I vote for no adjustment)

One additional point. Vast majority of people lower the amount of soldiers in training site. Should the default occupancy (value in use when the construction site of a trainingsite appears) be below maximum? IMHO yes, default either from config or if hard-coded, make it two.

[Noordfrees]

Should these be preferences of enforcing? In other words, if already-trained soldiers are not present, should the site remain idle or eventually obtain non-preferred untrained soldiers? If evade-1 soldiers are available, should they be out of luck if enforcing untrained only? (I vote for preferences, not enforcement)

I would vote for: PreferHeroes = current (new) behaviour; PreferAny = old behaviour; PreferRookies = enforce rookies only

Should the requirement of previous training depend on whether the previous training was give here or not (non-Frisians)? (currently not in code)

In my opinion this should not matter to the site

Should there be an option to require that the soldiers is at least on minimum level for all trainable arts (Frisians)? (currently not in code)
Should the discriminating level be user-adjustable, or should it follow the supply like now? (I vote for no adjustment)

Such options would clutter the UI too much IMHO, so I'm against them.

One additional point. Vast majority of people lower the amount of soldiers in training site. Should the default occupancy (value in use when the construction site of a trainingsite appears) be below maximum? IMHO yes, default either from config or if hard-coded, make it two.

The initial capacity should ideally go into the Lua file, and IMHO it should be 2 for (bar battle arena, emp arena, emp colosseum, atl labyrinth, fri traincamp) and 1 for the other sites.

[tppq]

PreferRookies = enforce rookies only

In the context of labyrinth, would attack only-trained be allowed in? Can do, I just have trouble figuring out why would one want that.

[Noordfrees]

I don't feel strongly about this, but IMHO Prefer Rookies mode should be the opposite behaviour of Prefer Heroes mode. So perhaps make it that the labyrinth prefers complete rookies if available, and when it can't get any it starts gradually to increase the tolerated attack level (while never accepting soldiers that have already received any training step this site can offer).

[hessenfarmer]

I believe this should go in b21 or we should revert #3835 as we already have the first bug report for the new behaviour see #3869

[Noordfrees]

And another forum thread (in german) https://www.widelands.org/forum/topic/5090
With another new idea for militarysite preferences: A fourth option "Prefer Average" that prefers soldiers whose training levels are close to the average levels of all the player's soldiers

[Noordfrees]

Updated the first post with all the good ideas from the new forum thread. I'm removing this from the milestone though because it is not a realistic expectation.