Name All UI Elements #5963
Merged
Name All UI Elements #5963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noordfrees
added
cleanup & refactoring
matthiakl
approved these changes
Jul 15, 2023
|
Thanks for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Refactoring
Issue(s) closed
This is part of the ongoing effort to make the Lua UI API more powerful. All panels are now named. The diff here is huge since all previously anonymous panels have to be given a name now. The only "actual" changes are very small and located in in
panel.*.Possible regressions
Bugs with creation of UI elements
Additional context
Note that names don't have to be unique; it is helpful if they are, but there are other ways for scripts to access panels if a panel's name is not known or not unique.
This branch will have merge conflicts with #5933 (and probably every other UI-related PR), but it doesn't really matter which one gets merged first.