Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow themes to override the dither edge mask #6452

Closed
wants to merge 2 commits into from
Closed

Allow themes to override the dither edge mask #6452

wants to merge 2 commits into from

Conversation

bunnybot
Copy link

NordfrieseMirrored from Codeberg
Created on Sun May 12 11:55:47 CEST 2024 by Benedikt Straub (Nordfriese)

Type of change
Enhancement

Issue(s) closed
Fixes https://www.widelands.org/forum/topic/5972

New behavior
The dither program's edge mask file is now also under the control of theme add-ons.

Possible regressions
The dither program's appearance

Screenshots
edge.png
shot0002.png

Additional context
Add any other context about the problem here.

@bunnybot bunnybot added this to the v1.3 milestone May 12, 2024
@bunnybot bunnybot self-assigned this May 12, 2024
@bunnybot
Copy link
Author

Assigned to Nordfriese

@bunnybot bunnybot added enhancement New feature or request world Critters, trees, terrains, ... graphics Animations, graphics files, graphics engine, OpenGL addon Problems and requests related to add-ons ci:success CI checks succeeded labels May 12, 2024
bunnybot
bunnybot commented May 12, 2024
View reviewed changes
Copy link
Author

@bunnybot bunnybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tothxaMirrored from Codeberg
On Sun May 12 22:54:25 CEST 2024, Tóth András (tothxa) commented:

Code looks reasonable. Not tested yet.

@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels May 17, 2024
bunnybot
bunnybot commented May 21, 2024
View reviewed changes
Copy link
Author

@bunnybot bunnybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tothxaMirrored from Codeberg
On Tue May 21 18:25:32 CEST 2024, Tóth András (tothxa) approved this pull request:

Tested too, works nicely.

@bunnybot bunnybot added the review:approve The pull request has been approved. label May 21, 2024
@bunnybot
Copy link
Author

hessenfarmerMirrored from Codeberg
On Tue May 21 22:17:22 CEST 2024, Stephan Lutz (hessenfarmer) wrote:

<@>bunnybot merge

@bunnybot
Copy link
Author

hessenfarmerMirrored from Codeberg
On Tue May 21 22:31:21 CEST 2024, Stephan Lutz (hessenfarmer) wrote:

<@>bunnybot update

@bunnybot bunnybot added ci:success CI checks succeeded and removed ci:success CI checks succeeded labels May 21, 2024
@bunnybot
Copy link
Author

hessenfarmerMirrored from Codeberg
On Wed May 22 07:46:19 CEST 2024, Stephan Lutz (hessenfarmer) wrote:

<@>bunnybot merge

@bunnybot bunnybot closed this May 22, 2024
@bunnybot bunnybot deleted the mirror/Nordfriese/widelands/dither-edge-theme branch May 22, 2024 05:49
bunnybot pushed a commit that referenced this pull request May 22, 2024
Allow themes to override the dither edge mask (CB #4814 / GH #6452)
34471fc 
Co-authored-by: Benedikt Straub <nordfriese@noreply.codeberg.org>
Co-committed-by: Benedikt Straub <nordfriese@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bunnybot bunnybot

Labels
addon Problems and requests related to add-ons ci:success CI checks succeeded enhancement New feature or request graphics Animations, graphics files, graphics engine, OpenGL review:approve The pull request has been approved. world Critters, trees, terrains, ...
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bunnybot @Noordfrees