Protocol version 6: Compatibility future-proofing and some enhancements #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noordfrees
added
enhancement
matthiakl
reviewed
Nov 21, 2021
matthiakl
approved these changes
Nov 22, 2021
|
Thanks for the review Merged and deployed, alpha is offline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing the protocol version for every minor feature will quickly make the code unmaintainable. The new protocol version gives every command its own independent command version, so that from now on changing a command's syntax requires updating only that one command's version handling and does not touch the global version.
The other two enhancements in this branch are the ability to append
CMD_INFOpayloads to theCMD_LISTresponse to speed up network communication if the client requests it; and to configure Tx resource properties viaCMD_SETUP_TXso it no longer requires the add-ons maintainer to have admin privileges on Transifex.