Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeviceFrame package is hard to use #112

Closed
jenshor opened this issue Feb 4, 2022 · 0 comments · Fixed by #114
Closed

DeviceFrame package is hard to use #112

jenshor opened this issue Feb 4, 2022 · 0 comments · Fixed by #114
Labels
t: feat New feature or request

Comments

@jenshor
Copy link
Member

jenshor commented Feb 4, 2022

Description
Currently the DeviceFrame can be used but a lot of customization has to be done by the developer. Since device_frame only has a freezed_annotation dependency (which is already a dependency of widgetbook) it would be more user friendly to include this into the widgetbook 2.x.x launch.
@jenshor jenshor added the t: feat New feature or request label Feb 4, 2022
@jenshor jenshor mentioned this issue Feb 7, 2022
Merged
@jenshor jenshor linked a pull request Feb 8, 2022 that will close this issue
feature: added device_frame to widgetbook #114
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t: feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: added device_frame to widgetbook widgetbook/widgetbook
1 participant
@jenshor