Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: added device_frame to widgetbook #114

Merged
merged 8 commits into from Feb 9, 2022
Merged

feature: added device_frame to widgetbook #114

merged 8 commits into from Feb 9, 2022

Conversation

jenshor
Copy link
Member

@jenshor jenshor commented Feb 7, 2022

  • Integrated device_frame into widgetbook.
  • added iPhone 13 models
  • changed device classes to feature freezed

List of issues which are fixed by the PR

#112

@jenshor jenshor self-assigned this Feb 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #114 (4707925) into main (13b16f1) will decrease coverage by 6.71%.
The diff coverage is 20.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   45.42%   38.70%   -6.72%     
==========================================
  Files         108      111       +3     
  Lines        1497     1922     +425     
==========================================
+ Hits          680      744      +64     
- Misses        817     1178     +361     
Impacted Files Coverage Δ
...ook/lib/src/rendering/builders/device_builder.dart 4.34% <0.00%> (-28.99%) ⬇️
...widgetbook/lib/src/rendering/widgetbook_frame.dart 66.66% <ø> (ø)
packages/widgetbook/lib/src/widgetbook.dart 13.09% <ø> (ø)
...getbook_models/lib/src/devices/device.freezed.dart 18.71% <18.71%> (ø)
...ook_models/lib/src/devices/resolution.freezed.dart 29.16% <29.16%> (ø)
...ok_models/lib/src/devices/device_size.freezed.dart 29.54% <29.54%> (ø)
...ages/widgetbook_models/lib/src/devices/device.dart 100.00% <100.00%> (ø)
...widgetbook_models/lib/src/devices/device_size.dart 100.00% <100.00%> (ø)
.../widgetbook_models/lib/src/devices/resolution.dart 100.00% <100.00%> (ø)
...ackages/widgetbook/lib/src/workbench/renderer.dart 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13b16f1...4707925. Read the comment docs.

@jenshor jenshor linked an issue Feb 8, 2022 that may be closed by this pull request
@jenshor jenshor requested a review from dkbast February 8, 2022 06:37
@jenshor jenshor changed the title Issue 112 feature: added device_frame to widgetbook Feb 9, 2022
@jenshor jenshor merged commit b1f404c into main Feb 9, 2022
@jenshor jenshor deleted the issue-112 branch February 9, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeviceFrame package is hard to use
2 participants