Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mobile support #1019

Merged
merged 14 commits into from Nov 7, 2023
Merged

feat: add mobile support #1019

merged 14 commits into from Nov 7, 2023

Conversation

Mastersam07
Copy link
Contributor

@Mastersam07 Mastersam07 commented Oct 31, 2023 •
edited

Mobile support

List of issues which are fixed by the PR

#805

Screen record

mobileSupport.mov

Checklist

  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making].
  • All existing and new tests are passing.

If you need help, consider asking for advice on Discord.

@Mastersam07 Mastersam07 mentioned this pull request Oct 31, 2023
Closed
@Mastersam07 Mastersam07 marked this pull request as ready for review November 2, 2023 12:00
@Mastersam07
Copy link
Contributor Author

@YoussefRaafatNasry This PR is ready for review.

@YoussefRaafatNasry YoussefRaafatNasry changed the title feat: mobile support feat: add mobile support Nov 2, 2023
@Mastersam07
Copy link
Contributor Author

@YoussefRaafatNasry adjusted the PR.

@YoussefRaafatNasry
Copy link
Member

Thanks @Mastersam07 for the awesome feature addition! 💙
We will take it from here to add some color, codestyle, and minor layout changes.

@YoussefRaafatNasry YoussefRaafatNasry merged commit 7f30df0 into widgetbook:main Nov 7, 2023
6 checks passed
@YoussefRaafatNasry YoussefRaafatNasry linked an issue Nov 7, 2023 that may be closed by this pull request
Mobile Support #805
Closed
@Mastersam07 Mastersam07 deleted the feat/mobile-support branch November 8, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoussefRaafatNasry YoussefRaafatNasry YoussefRaafatNasry approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mobile Support
2 participants
@Mastersam07 @YoussefRaafatNasry