Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace knobs value with initialValue #1025

Merged
merged 1 commit into from Nov 2, 2023
Merged

refactor: replace knobs value with initialValue #1025

merged 1 commit into from Nov 2, 2023

Conversation

YoussefRaafatNasry
Copy link
Member

@YoussefRaafatNasry YoussefRaafatNasry commented Nov 2, 2023 •
edited

The Knob's value was only used as an initialValue for Fields. It has no other purposes. Even calls to KnobRegistry.updateValue were redundant due to the fact that register uses Knob.valueFromQueryGroup and not Knob.value.

To make things more clear, we will be deprecating Knob.value in favor of Knob.initialValue. In addition, KnobRegistry.updateValue is deprecated as well, and currently it's a no-op.

@YoussefRaafatNasry YoussefRaafatNasry self-assigned this Nov 2, 2023
@YoussefRaafatNasry YoussefRaafatNasry marked this pull request as ready for review November 2, 2023 16:27
@YoussefRaafatNasry YoussefRaafatNasry merged commit e7cc719 into main Nov 2, 2023
5 checks passed
@YoussefRaafatNasry YoussefRaafatNasry deleted the refactor/knob-initial-value branch November 2, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@YoussefRaafatNasry YoussefRaafatNasry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@YoussefRaafatNasry