fix: enable InspectorAddon on release builds
#1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
YoussefRaafatNasry
requested changes
Dec 13, 2023
packages/widgetbook/lib/src/addons/inspector_addon/inspector_addon.dart
Outdated
Show resolved
Hide resolved
YoussefRaafatNasry
changed the title
InspectorAddon on release builds
YoussefRaafatNasry
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By passing
enabledto theInspectorwidget we ensure that the inspector is properly toggled for release builds. See issue below for further details.List of issues which are fixed by the PR
Screenshots
For the following screenshots I ran
flutter build weband then ran the build withdhhtpd.First is before change, and second is with my change, where you can see the
Inspectoris now shown.Checklist
///).If you need help, consider asking for advice on Discord.