Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop go_router dependency #625

Merged
merged 2 commits into from
May 26, 2023
Merged

refactor: drop go_router dependency #625

merged 2 commits into from
May 26, 2023

Conversation

YoussefRaafatNasry
Copy link
Member

@YoussefRaafatNasry YoussefRaafatNasry commented Apr 12, 2023 •
edited
Loading

Routing in Widgetbook is so simple that it doesn't need a package.

@docs-page
Copy link

docs-page bot commented Apr 12, 2023

To view this pull requests documentation preview, visit the following URL:

docs.widgetbook.io/~625

Documentation is deployed and generated using docs.page.

@YoussefRaafatNasry YoussefRaafatNasry marked this pull request as draft April 12, 2023 14:29
@YoussefRaafatNasry YoussefRaafatNasry self-assigned this Apr 12, 2023
@github-actions
Copy link

📦 Build

@YoussefRaafatNasry YoussefRaafatNasry linked an issue Apr 12, 2023 that may be closed by this pull request
Issue: Widgetbook and GoRoute #342
Closed
@github-actions
Copy link

📦 Build

@YoussefRaafatNasry YoussefRaafatNasry force-pushed the refactor/remove-go-router branch 2 times, most recently from 76f38e0 to f0966de Compare April 13, 2023 14:04
@github-actions
Copy link

📦 Build

@github-actions
Copy link

📦 Build

@github-actions
Copy link

📦 Build

@github-actions
Copy link

📦 Build

@YoussefRaafatNasry YoussefRaafatNasry mentioned this pull request Apr 16, 2023
Merged
@YoussefRaafatNasry YoussefRaafatNasry force-pushed the refactor/remove-go-router branch 2 times, most recently from 2333484 to 41193b4 Compare May 16, 2023 15:08
@YoussefRaafatNasry YoussefRaafatNasry marked this pull request as ready for review May 25, 2023 11:28
@YoussefRaafatNasry YoussefRaafatNasry mentioned this pull request May 25, 2023
Closed
jenshor
jenshor approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@jenshor jenshor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🎉 always feels good to drop a dependency!

@YoussefRaafatNasry YoussefRaafatNasry merged commit 01e86cb into main May 26, 2023
4 checks passed
@YoussefRaafatNasry YoussefRaafatNasry deleted the refactor/remove-go-router branch May 26, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenshor jenshor jenshor approved these changes

Assignees

@YoussefRaafatNasry YoussefRaafatNasry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue: Widgetbook and GoRoute
2 participants
@YoussefRaafatNasry @jenshor