Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop provider dependency #682

Merged
merged 3 commits into from
May 19, 2023
Merged

Conversation

YoussefRaafatNasry
Copy link
Member

@YoussefRaafatNasry YoussefRaafatNasry commented May 19, 2023

provider was only used for KnobsNotifier. By merging KnobsNotifier into WidgetbookState, there's no more need for the provider package.

@docs-page
Copy link

docs-page bot commented May 19, 2023

To view this pull requests documentation preview, visit the following URL:

docs.widgetbook.io/~682

Documentation is deployed and generated using docs.page.

@YoussefRaafatNasry YoussefRaafatNasry changed the title refactor/remove provider refactor: drop provider dependency May 19, 2023
@YoussefRaafatNasry YoussefRaafatNasry self-assigned this May 19, 2023
@YoussefRaafatNasry YoussefRaafatNasry force-pushed the refactor/remove-provider branch 2 times, most recently from 35049ee to 70fbc6c Compare May 19, 2023 10:26
@YoussefRaafatNasry YoussefRaafatNasry changed the base branch from main to refactor/improve-lints May 19, 2023 10:27
@github-actions
Copy link

📦 Build

📑 Review

Copy link
Member

@jenshor jenshor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉 One less dependency 💪🏻

jenshor

This comment was marked as duplicate.

Base automatically changed from refactor/improve-lints to main May 19, 2023 14:33
@YoussefRaafatNasry YoussefRaafatNasry merged commit 2fa4757 into main May 19, 2023
4 checks passed
@YoussefRaafatNasry YoussefRaafatNasry deleted the refactor/remove-provider branch May 19, 2023 14:40
@YoussefRaafatNasry YoussefRaafatNasry linked an issue May 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KnobsBuilder should be exported
2 participants