fix: use labelBuilder for equality in list knob
#729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
jazz-mobility
approved these changes
Jun 7, 2023
BrunooShow
approved these changes
Jun 8, 2023
YoussefRaafatNasry
changed the title
labelBuilder for equality in list knob
YoussefRaafatNasry
approved these changes
Jun 8, 2023
There was a problem hiding this comment.
Great fix, @nuesslerm! Keep it up 🎉
I did some changes, to be able to merge it to main:
- Excluding irrelevant changes in
knbos_example. - Adding CHANGELOG entry for the fix.
Consider these in your future PRs, to get a faster merge.
|
@YoussefRaafatNasry thanks will do. 🙏 |
|
@nuesslerm No worries about the failing job. |
|
thanks! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of issues which are fixed by the PR
#730
Description
list knobs with labelBuilder or non-string values can fail to update
Steps To Reproduce
Screenshots
Screen.Recording.2023-06-07.at.21.15.00.mov
Checklist
///).If you need help, consider asking for advice on Discord.