Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): use ListView for SettingsPanel #732

Merged
merged 1 commit into from Jun 8, 2023

Conversation

YoussefRaafatNasry
Copy link
Member

@YoussefRaafatNasry YoussefRaafatNasry commented Jun 8, 2023

Using the Column/Expanded combo inside SingleChildScrollView caused the following error due to the unconstrained expansion:

════════ Exception caught by widgets library ═══════════════════════════════════
RenderBox was not laid out: RenderMouseRegion#c3514 NEEDS-LAYOUT NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE
'package:flutter/src/rendering/box.dart':
box.dart:1
Failed assertion: line 1966 pos 12: 'hasSize'

The relevant error-causing widget was
DropdownMenu<DeviceInfo?>
dropdown_setting.dart:25
════════════════════════════════════════════════════════════════════════════════

@docs-page
Copy link

docs-page bot commented Jun 8, 2023

To view this pull requests documentation preview, visit the following URL:

docs.widgetbook.io/~732

Documentation is deployed and generated using docs.page.

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

📦 Build

📑 Review

@YoussefRaafatNasry YoussefRaafatNasry merged commit 4c750e0 into main Jun 8, 2023
7 checks passed
@YoussefRaafatNasry YoussefRaafatNasry deleted the fix/setting-panel-layout branch June 8, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The relevant error-causing widget was DropdownMenu<WidgetbookTheme<ThemeData>>
2 participants