-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make side panels resizable #738
Conversation
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
…tbook into feat/resize_windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work contributing to fix this! 🎉
Although this PR uses an external package, which is something we really not in fan of lately after removing most of our dependencies (bloc, provider, freezed, etc.). But I can see that the resizable_widget
package:
- is somehow stable and doesn't get a lot of updates.
- is not commonly used by mobile app developers (the big percent of Flutter users), so it won't result in version conflicts.
@@ -17,8 +18,10 @@ class WidgetbookShell extends StatelessWidget { | |||
|
|||
return ColoredBox( | |||
color: Theme.of(context).colorScheme.surface, | |||
child: Row( | |||
crossAxisAlignment: CrossAxisAlignment.stretch, | |||
child: ResizableWidget( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kiruel I modified this code a bit as follows:
- Sort
children
to be the last parameter for more readability. - Remove
Material
widget; You probably ran into this issue because you've used the hosted version ofwidgetbook_core
and not the local one. We use melos to manage dependencies, so consider usingmelos bs
instead offlutter pub get
in your future PRs.
Adding resize windows for widgetbook shell.
List of issues which are fixed by the PR
fix #621
Screenshots
If applicable, add screenshots to help explain the changes.
Checklist
///
).If you need help, consider asking for advice on Discord.