Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace null device with NoneDevice #854

Merged
merged 2 commits into from Aug 18, 2023

Conversation

YoussefRaafatNasry
Copy link
Member

@YoussefRaafatNasry YoussefRaafatNasry commented Aug 18, 2023

The null device caused some trouble with the Field system, that will take a while to fix properly. This is a temporary workaround that fixes the issue when DeviceFrameAddon had a initialValue, it could not be set back to None.

@docs-page
Copy link

docs-page bot commented Aug 18, 2023

To view this pull requests documentation preview, visit the following URL:

docs.widgetbook.io/~854

Documentation is deployed and generated using docs.page.

@YoussefRaafatNasry YoussefRaafatNasry self-assigned this Aug 18, 2023
@YoussefRaafatNasry YoussefRaafatNasry merged commit 8bdf284 into main Aug 18, 2023
5 checks passed
@YoussefRaafatNasry YoussefRaafatNasry deleted the refactor/none-device branch August 18, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant