Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove false overriding for listOrNull knob #881

Merged
merged 1 commit into from Sep 4, 2023

Conversation

YoussefRaafatNasry
Copy link
Member

@YoussefRaafatNasry YoussefRaafatNasry commented Sep 4, 2023

The following debugging-lines skipped through the review process, probably due to the lack of tests:

// Force non-nullable behavior
@override
bool get isNullable => false;

They were removed and some tests were added to prevent it from happening again in the future.

@docs-page
Copy link

docs-page bot commented Sep 4, 2023

To view this pull requests documentation preview, visit the following URL:

docs.widgetbook.io/~881

Documentation is deployed and generated using docs.page.

@YoussefRaafatNasry YoussefRaafatNasry self-assigned this Sep 4, 2023
@YoussefRaafatNasry YoussefRaafatNasry merged commit 5835aba into main Sep 4, 2023
5 checks passed
@YoussefRaafatNasry YoussefRaafatNasry deleted the fix/list-knob branch September 4, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant