Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: maintain navigation panel state on reload #932

Merged
merged 6 commits into from
Oct 6, 2023

Conversation

khurramrizvi
Copy link
Contributor

@khurramrizvi khurramrizvi commented Oct 4, 2023

List of issues which are fixed by the PR

fixed navigation panel selection on page refresh

Checklist

  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making.
  • All existing and new tests are passing.

If you need help, consider asking for advice on Discord.

@khurramrizvi
Copy link
Contributor Author

PR addressing issue #796

@YoussefRaafatNasry YoussefRaafatNasry linked an issue Oct 5, 2023 that may be closed by this pull request
Copy link
Member

@YoussefRaafatNasry YoussefRaafatNasry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with spotting where the bug is!

We need to add an entry in CHANGELOG.md to let other people know that this is no longer an issue.

@YoussefRaafatNasry YoussefRaafatNasry changed the title [navigation-fix] fixed navigation panel selection on page refresh fix: maintain navigation panel state on reload Oct 5, 2023
@YoussefRaafatNasry YoussefRaafatNasry merged commit a41815d into widgetbook:main Oct 6, 2023
5 checks passed
@YoussefRaafatNasry
Copy link
Member

Thanks @khurramrizvi for making Widgetbook better 💙
This PR is part of Hacktoberfest Program and we will post more details by the end of the month.
Until then, keep the bug-fix up!

@YoussefRaafatNasry
Copy link
Member

Hello @khurramrizvi! 👋
Please reach us out on this email to claim your Hacktoberfest swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation Panel Loses Focus on Refresh
2 participants