Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add duration knob #934

Merged
merged 8 commits into from
Oct 6, 2023
Merged

feat: add duration knob #934

merged 8 commits into from
Oct 6, 2023

Conversation

Mastersam07
Copy link
Contributor

@Mastersam07 Mastersam07 commented Oct 4, 2023 •
edited
Loading

Adds duration knob.

Duration should be entered in milliseconds (1000 milliseconds == 1 second).

List of issues which are fixed by the PR

#900

Screenrecord

durationField.mov

Checklist

  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making].
  • All existing and new tests are passing.

If you need help, consider asking for advice on Discord.

@Mastersam07
feat: add duration knob
33fb773 
feat: add tests
@Mastersam07
Copy link
Contributor Author

Hi @YoussefRaafatNasry can you please take a look/review?

@Mastersam07
Update CHANGELOG.md to include PR number
73d6932 
doc: add duration field to example

chore: remove decoration label from duration field

chore: fix typo
@YoussefRaafatNasry YoussefRaafatNasry linked an issue Oct 5, 2023 that may be closed by this pull request
Duration Knob #900
Closed
YoussefRaafatNasry
YoussefRaafatNasry requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@YoussefRaafatNasry YoussefRaafatNasry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really love how professional this PR is! 💙
You have done a good job with neat implementation, adding tests, Changelog item, even a video and an example.

I've added some nitpick comments that will make the code style more matching to ours, and will improve the UX!

Can't wait to get this merged and released!

packages/widgetbook/lib/src/knobs/duration_knob.dart Show resolved Hide resolved
packages/widgetbook/lib/src/fields/duration_field.dart Outdated Show resolved Hide resolved
packages/widgetbook/lib/src/fields/duration_field.dart Outdated Show resolved Hide resolved
packages/widgetbook/lib/src/fields/duration_field.dart Outdated Show resolved Hide resolved
packages/widgetbook/lib/src/fields/duration_field.dart Show resolved Hide resolved
@Mastersam07
Copy link
Contributor Author

Really love how professional this PR is! 💙 You have done a good job with neat implementation, adding tests, Changelog item, even a video and an example.

I've added some nitpick comments that will make the code style more matching to ours, and will improve the UX!

Can't wait to get this merged and released!

Made the changes and added their respective test groups.

YoussefRaafatNasry
YoussefRaafatNasry requested changes Oct 6, 2023
View reviewed changes
Copy link
Member

@YoussefRaafatNasry YoussefRaafatNasry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little thing I forgot to mention, but we will really appreciate if you could add the new knobs to the docs as well.

packages/widgetbook/lib/src/knobs/builders/knobs_builder.dart Outdated Show resolved Hide resolved
@Mastersam07
Copy link
Contributor Author

@YoussefRaafatNasry I have made the changes.

YoussefRaafatNasry
YoussefRaafatNasry approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@YoussefRaafatNasry YoussefRaafatNasry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Mastersam07!

@YoussefRaafatNasry YoussefRaafatNasry merged commit 0df596a into widgetbook:main Oct 6, 2023
5 checks passed
@Mastersam07 Mastersam07 deleted the feat/duration_knob branch October 6, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoussefRaafatNasry YoussefRaafatNasry YoussefRaafatNasry approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duration Knob
2 participants
@Mastersam07 @YoussefRaafatNasry