feat: add dateTime knob #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logickoder/feat/date-time-knob # Conflicts: # examples/knobs_example/lib/home_page.dart # examples/knobs_example/lib/widgetbook.dart # packages/widgetbook/lib/src/fields/field_type.dart # packages/widgetbook/lib/src/knobs/builders/knobs_builder.dart
|
Hi @YoussefRaafatNasry can you please take a look/review? |
YoussefRaafatNasry
changed the title
Closed
YoussefRaafatNasry
requested changes
Oct 8, 2023
There was a problem hiding this comment.
Thanks a lot for your time and effort on this new knob 💙
Many people will find this useful! You have done a good job covering everything from docs to tests.
Because DateTime is one of the complicated data types, I've added some comments to simplify and improve the implementation a bit.
I will review this again once we get these comments done, because the implementation will change a bit. Let me know if you need any further help or any more info on any of the comments.
|
Hi @YoussefRaafatNasry I have made some changes, can you review again? |
…logickoder/feat/date-time-knob
YoussefRaafatNasry
requested changes
Oct 9, 2023
…logickoder/feat/date-time-knob # Conflicts: # packages/widgetbook/CHANGELOG.md
|
Hi @YoussefRaafatNasry I have made some changes, can you review again? |
YoussefRaafatNasry
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a DateTime Knob
List of issues which are fixed by the PR
#899
Screenshots
knobs_example.2023-10-06.15-15-33.mp4
Checklist
///).If you need help, consider asking for advice on Discord.