Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add inspector addon #985

Merged
merged 5 commits into from
Oct 12, 2023

Conversation

Mastersam07
Copy link
Contributor

Inspect Addon

List of issues which are fixed by the PR

#984

Screenrecord

inspect.mp4

Checklist

  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making].
  • All existing and new tests are passing.

If you need help, consider asking for advice on Discord.

@Mastersam07 Mastersam07 changed the title feat: inspect addon feat: add inspect addon Oct 11, 2023
@YoussefRaafatNasry YoussefRaafatNasry changed the title feat: add inspect addon feat: add inspector addon Oct 12, 2023
Copy link
Member

@YoussefRaafatNasry YoussefRaafatNasry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! This will be a really helpful addon for all users.

We just need to name all occurances of "inspect" addon to "inspector" addon, this includes files, docs, code, etc.

docs/addons/inspect-addon.mdx Outdated Show resolved Hide resolved
@Mastersam07
Copy link
Contributor Author

Changes made as requested. @YoussefRaafatNasry

Copy link
Member

@YoussefRaafatNasry YoussefRaafatNasry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mastersam07 There are still a lot of files/folders named inspect_addon instead of inspector_addon:

  • docs/addons/inspect-addon.mdx
  • packages/widgetbook/lib/src/addons/inspect_addon/inspect_addon.dart (file and folder)
  • packages/widgetbook/test/src/addons/inspect_addon_test.dart

@YoussefRaafatNasry YoussefRaafatNasry linked an issue Oct 12, 2023 that may be closed by this pull request
@Mastersam07
Copy link
Contributor Author

@Mastersam07 There are still a lot of files/folders named inspect_addon instead of inspector_addon:

  • docs/addons/inspect-addon.mdx
  • packages/widgetbook/lib/src/addons/inspect_addon/inspect_addon.dart (file and folder)
  • packages/widgetbook/test/src/addons/inspect_addon_test.dart

Alright. Done.

@YoussefRaafatNasry YoussefRaafatNasry merged commit 64c2cde into widgetbook:main Oct 12, 2023
5 checks passed
@YoussefRaafatNasry YoussefRaafatNasry linked an issue Nov 3, 2023 that may be closed by this pull request
@Mastersam07 Mastersam07 deleted the feat/inspect-addon branch November 8, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspector Addon Widgets Inspector
2 participants