Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR-154] Optimistic messages #44

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

JohnyTheCarrot
Copy link
Contributor

image

Just add optimistic: true to the message data to make it optimistic.

@JohnyTheCarrot JohnyTheCarrot changed the title [FR-154] feat: optimistic messages [FR-154] Optimistic messages Oct 18, 2023
@JohnyTheCarrot JohnyTheCarrot linked an issue Oct 22, 2023 that may be closed by this pull request
src/types.ts Outdated
@@ -0,0 +1,5 @@
import type { APIMessage } from "discord-api-types/v10";

export interface DiscordMessage extends APIMessage {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really discord specific imo - optimistic should simply be a feature to allow us to dim the message to show that it is in a sending state

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean.

@JohnyTheCarrot JohnyTheCarrot merged commit 525df59 into development Nov 14, 2023
@JohnyTheCarrot JohnyTheCarrot deleted the feat/optimistic-messages branch November 14, 2023 11:13
@Yomanz
Copy link
Member

Yomanz commented Apr 26, 2024

Closed #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimistic messages support
3 participants