Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix video embeds to check proxy_url for null #52

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix video embeds to check proxy_url for null #52

merged 1 commit into from
Apr 18, 2024

Conversation

JohnyTheCarrot
Copy link
Contributor

No description provided.

@JohnyTheCarrot JohnyTheCarrot requested review from advaith1 and a team April 12, 2024 16:06
@JohnyTheCarrot JohnyTheCarrot self-assigned this Apr 12, 2024
@JohnyTheCarrot JohnyTheCarrot requested review from Yomanz and removed request for a team April 12, 2024 16:06
Yomanz
Yomanz approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@Yomanz Yomanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid

@JohnyTheCarrot JohnyTheCarrot merged commit a187958 into development Apr 18, 2024
Yomanz pushed a commit that referenced this pull request Apr 26, 2024
@JohnyTheCarrot @Yomanz
fix: video embeds' proxy_url was not checked for null (#52)
aa67ef6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yomanz Yomanz Yomanz approved these changes

@advaith1 advaith1 advaith1 approved these changes

@mason-rogers mason-rogers mason-rogers approved these changes

Assignees

@JohnyTheCarrot JohnyTheCarrot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JohnyTheCarrot @Yomanz @advaith1 @mason-rogers