Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solara.rootPath duplicated into popout url #12

Closed
iisakkirotko opened this issue Jan 26, 2024 · 0 comments · Fixed by #13
Closed

solara.rootPath duplicated into popout url #12

iisakkirotko opened this issue Jan 26, 2024 · 0 comments · Fixed by #13

Comments

@iisakkirotko
Copy link
Collaborator

iisakkirotko commented Jan 26, 2024

When using solara, the URL opened by ipypopout is currently given by:

const result = `${host}${baseUrl}${this.popoutPageUrl}` +
`?kernelid=${this.kernel_id}&modelid=${this.target_model_id}&baseurl=${baseUrl}` + (isDark ? '&dark=true' : '');

with baseUrl given by

getBaseUrl() {
const labConfigData = document.getElementById('jupyter-config-data');
if (labConfigData) {
/* lab and Voila */
return JSON.parse(labConfigData.textContent).baseUrl;
}
return document.body.dataset.baseUrl
},

which in solara goes to {{root_path}}/and this.popoutPageUrl = solara.rootPath (= root_path).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant