-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event serialization breaks "simple" events #78
Comments
Thank you for the issue Michael, #79 should fix this. |
Thanks for the quick work on this, @maartenbreddels! I did try to have a go, but got stuck on wanting to write tests, so I'm happy there is now an example on how to do that. Just as a heads up, we actually stumbled across this issue although we were using an older version of We fixed voila by rather serving the extensions directly (we are still < 0.5.0, so --enable_nbextensions worked) instead of from CDN, but I couldn't figure out why going from CDN was referencing newer code. Re jupyter lab, I swear it wasn't working yesterday, but now it is, so maybe something got fixed here? I can try to have a look and make a reproducible test case, unless you have an idea where that could have come from? |
Due to Line 155 in 8e907a7
Line 2 in 8e907a7
@mariobuikhuizen I think we should not do that, it makes cdn fetching different from a local install, and to me makes no sense whatsoever. I think we could do "~x.y.z" but a strict match "x.y.z" might make more sense. In Jupyter Lab it could be that you've hit a cache issue? Maybe it was using JS assets from cache? If you like voila+ipyvuetify (assuming you also use ipyvuetify) you might also be interested in https://github.com/widgetti/solara/ |
Ok, thx. +1 for having the strict match, then it's on the user to explicitly upgrade, I like reproducible environments! :-) Thanks for the tip on solara, yes, we have been happy with voila + ipyvuetify + others, it has been our production "dashboard" server for internal use for almost 4 years. :-) I'll have to take a look at solara. |
Recent updates (e.g. #76) to event serialization have broken more simple events, e.g. the change events of Tabs that expect to deliver a string. Other examples are change events of e.g. Select boxes.
Example (using ipyvuetify, but I did determine the changes arise from the code touched above):
which will output (on clicking the tabs):
instead of the expected:
The text was updated successfully, but these errors were encountered: