Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: improve ci #299

Merged
merged 4 commits into from
Feb 28, 2024
Merged

ci: improve ci #299

merged 4 commits into from
Feb 28, 2024

Conversation

mariobuikhuizen
Copy link
Collaborator

No description provided.

@mariobuikhuizen mariobuikhuizen force-pushed the ci_fix_npm_release branch 8 times, most recently from 0ace624 to 8e70d5d Compare February 26, 2024 16:14
@mariobuikhuizen
ci: fix npm release
a9daf13 
- npm pack was missing in the build job and was not available in the
  release job.
- Remove the prepare script, so npm pack/publish doesn't build the
  package again.
- Remove unneccesarry files from the distribution. the js directory
  was included which also included the very big node_modules dir.
  We can consider the transpiled js as source for the source
  distribution.
- Add a release-dry-run job that always runs to
  discover these issues early.
@mariobuikhuizen mariobuikhuizen force-pushed the ci_fix_npm_release branch 2 times, most recently from b427669 to f95f13a Compare February 28, 2024 13:52
@mariobuikhuizen mariobuikhuizen changed the title ci: fix npm release ci: improve ci Feb 28, 2024
@mariobuikhuizen mariobuikhuizen merged commit 8a6a636 into master Feb 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mariobuikhuizen