Skip to content

Commit

Permalink
fix: solara.display not working on some mimetypes in production mode
Browse files Browse the repository at this point in the history
These dependencies were aliased to an empty file to save on bundle size in 242d7e2, but turn out to be necessary for the rendering of some mimetypes. Because the aliasing takes place during the minification step, development mode still worked, but running in production mode would show a javascript error.
  • Loading branch information
iisakkirotko committed May 1, 2024
1 parent 18e2f49 commit 668372f
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions packages/solara-vuetify-app/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,7 @@ module.exports = [
"@widgetti/solara-widget-manager": "@widgetti/solara-widget-manager8",
// why would we need codemirror?
'@jupyterlab/codemirror': path.resolve(__dirname, "src", "empty.js"),
// used in @jupyterlab/rendermine/lib/registry
'@jupyterlab/apputils/lib/sanitizer': path.resolve(__dirname, "src", "empty.js"),
// do not think we use these
'htmlparser2': path.resolve(__dirname, "src", "empty.js"),
'postcss': path.resolve(__dirname, "src", "empty.js"),
'moment': path.resolve(__dirname, "src", "empty.js"),
}
Expand Down

0 comments on commit 668372f

Please sign in to comment.