fix: make altair work in Jupyter notebook and Jupyter Lab #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
fix_altair_in_jupyter
branch
2 times, most recently
from
a8253db
to
416557f
Compare
maartenbreddels
changed the title
Because the vega url does not end with .js the CdnHandler does not serve the file with the correct mimetype. We do not store the mime type on disk, so we do not know the mimetype of the file. Currently, the mimetype is guessed based on the file extension. By giving a more explicit path that ends in .js, we can make sure the mimetype is set correctly. In the end this caused the Altair component not to work.
Jupyter Lab does not provide requirejs, so we need to load it ourselves similar to what we do in other vue templates.
maartenbreddels
force-pushed
the
fix_altair_in_jupyter
branch
from
416557f
to
1ba4301
Compare
|
failures are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the non-colab part of #287