fix: avoid re-render when using sidebar or appbar #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 3, 2023
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Nov 3, 2023
maartenbreddels
changed the base branch from
11-01-feat_support_for_ipyvue_and_ipyvuetify_v3
to
master
maartenbreddels
force-pushed
the
11-03-fix_avoid_re-render_when_using_sidebar_or_appbar
branch
2 times, most recently
from
f202a5e
to
dcbec29
Compare
Before we had a 'fast path' which did not render the nav drawer and appbar when not used. This caused a different component tree to be rendered, which caused a re-render of the entire app. This also causes our parent div to always be the same, which will make the app behave more consistently (always 100vh parent). Fixes #331
otherwise screenshots will be different every time
maartenbreddels
force-pushed
the
11-03-fix_avoid_re-render_when_using_sidebar_or_appbar
branch
from
dcbec29
to
0489c81
Compare
maartenbreddels
added a commit
that referenced
this pull request
Nov 16, 2023
Note that this fixes #366 which was a breaking change, which was not yet released. So this is not a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we had a 'fast path' which did not render the nav drawer and
appbar when not used. This caused a different component tree to be
rendered, which caused a re-render of the entire app.
This also causes our parent div to always be the same, which will
make the app behave more consistently (always 100vh parent).
Fixes #331