fix: on hot reload esm modules were created multiple times #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maartenbreddels and the rest of your teammates on |
This was causing frontend code to sometimes use the old version, and sometimes the new version. With antd and theming sometimes the theme would not be applied (antd would probably not recognize the theme object with from the old antd esm).
maartenbreddels
force-pushed
the
03-14-fix_on_hot_reload_esm_modules_were_created_multiple_times
branch
from
6918956
to
a0e8279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing frontend code to sometimes use the old version, and
sometimes the new version. With antd and theming sometimes the theme
would not be applied (antd would probably not recognize the theme object
with from the old antd esm).