Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: AJAX Upgrades #1572

Merged
merged 19 commits into from
May 31, 2024
Merged

Enhancement: AJAX Upgrades #1572

merged 19 commits into from
May 31, 2024

Conversation

hansmorb
Copy link
Contributor

@hansmorb hansmorb commented Apr 6, 2024

Was
Eigener Tab unter "Migration" der nur angezeigt wird, wenn ein längerer Upgrade Prozess nötig ist.

image

Wie

Neue AJAX Action namens cb_run_upgrade und ein eigenes Array, in dem die Funktionen definiert werden, die bei einem Upgrade ausgeführt werden. Die Funktionen zum Abruf der Posts die upgegradet werden müssen, müssen paginated sein. Aber das geht easy mit WP_Query.

Warum

Häufige Timeouts bei größeren Installationen (Heavy User), wenn auf eine neue Version geupdatet werden soll. Darüber hinaus hilft, wenn wir z.B. später die Buchungen auf eine eigene Tabelle migrieren wollen, müssen wir dafür keine eigene AJAX Action anlegen.

closes #1571

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 81.42857% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 47.84%. Comparing base (cc6d223) to head (3dfc736).
Report is 2 commits behind head on master.

Files Patch % Lines
src/View/Migration.php 0.00% 18 Missing ⚠️
src/Repository/Timeframe.php 78.26% 5 Missing ⚠️
src/Service/Upgrade.php 96.96% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1572      +/-   ##
============================================
+ Coverage     47.51%   47.84%   +0.33%     
- Complexity     2581     2597      +16     
============================================
  Files            95       95              
  Lines         10214    10318     +104     
============================================
+ Hits           4853     4937      +84     
- Misses         5361     5381      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hansmorb hansmorb added enhancement New feature or request php Pull requests that update Php code javascript Pull requests that update Javascript code labels Apr 8, 2024
@hansmorb hansmorb marked this pull request as ready for review April 8, 2024 21:50
@hansmorb hansmorb added this to the Heavy User Funktionen milestone Apr 8, 2024
# Conflicts:
#	src/Service/Upgrade.php
#	tests/php/Service/UpgradeTest.php
@hansmorb hansmorb modified the milestones: Heavy User Funktionen, 2.10 May 29, 2024
# Conflicts:
#	assets/admin/js/admin.min.js
@hansmorb hansmorb merged commit 206684e into master May 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade als AJAX action
1 participant