fix #1576

src/Plugin.php

@@ -724,6 +724,9 @@ public function init() {
 		add_action( 'wp_enqueue_scripts', array( Plugin::class, 'addWarmupAjaxToOutput' ) );
 		add_action( 'admin_enqueue_scripts', array( Plugin::class, 'addWarmupAjaxToOutput' ) );
 
+		//Add custom hook to clear cache from cronjob
+		add_action( self::$clearCacheHook, array( $this, 'clearCache' ) );
+
 		add_action('plugins_loaded', array($this, 'commonsbooking_load_textdomain'), 20);
 
 		$map_admin = new LocationMapAdmin();
@@ -805,7 +808,7 @@ public function savePostActions( $post_id, $post, $update ) {
 		if ( ! in_array( $post->post_status, $ignoredStates ) || $update ) {
 			$tags   = Wordpress::getRelatedPostIds( $post_id );
 			$tags[] = 'misc';
-			self::clearCache( $tags );
+			self::scheduleClearCache( $tags );
 		}
 	}
 

src/Service/Cache.php

@@ -17,6 +17,12 @@
 
 trait Cache {
 
+	/**
+	 * TODO: Refactor to constant after PHP 8.2
+	 * @var string
+	 */
+	private static string $clearCacheHook = COMMONSBOOKING_PLUGIN_SLUG . '_clear_cache';
+
 	/**
 	 * Returns cache item based on calling class, function and args.
 	 *
@@ -196,6 +202,22 @@ public static function clearCache( array $tags = [] ) {
 		set_transient("clearCacheHasBeenDone", true, 45);
 	}
 
+	/**
+	 * Calls clearCache using WP Cron.
+	 * Why? ClearCache can be resource intensive on larger instances and should be offloaded.
+	 *
+	 * @param array $tags
+	 *
+	 * @return void
+	 */
+	public static function scheduleClearCache( array $tags = [] ) {
+		$event = wp_schedule_single_event( time(), self::$clearCacheHook, [ $tags ] );
+		if ( is_wp_error( $event ) ) {
+			//run the event right away when scheduling fails
+			self::clearCache( $tags );
+		}
+	}
+
 	/**
 	 * Add js to frontend on cache clear.
 	 * @return void

src/Wordpress/CustomPostType/Timeframe.php

@@ -944,6 +944,7 @@ protected static function validateTimeFrame( $timeframe ): bool {
 
 	/**
 	 * Will update the dynamic item / location assignment for all timeframes.
+	 * Only valid for timeframes which can have a dynamic selection type (so far only holidays and repair timeframes)
 	 *
 	 * @return void
 	 */
@@ -953,7 +954,6 @@ public static function updateAllTimeframes() {
 			[],
 			[
 				Timeframe::HOLIDAYS_ID,
-				Timeframe::BOOKABLE_ID,
 				Timeframe::REPAIR_ID
 			]
 		);